Another simple Java Question from a newbie.

[TheMindRapist]

That was probably added by mistake - using next is fine since "yes" or "no" is only one word.

No, I think it is better to use nextLine in place of next. I believe his error was that by using next he read the line without advancing to the next line, then when the loop was ran next there was nothing left in the line to assign to sentence. sentence then became null, thus a length of 0, thus an IndexOutOfBounds error. I could be wrong though, it's been a few years since I used Java.

Edit: s/a/an

Editx2: I should have mentioned that redeclaring/making a local variable the Scanner object worked because then it's new, so it starts with the next line of input, kind of artificially moving past the end of the reply line, even though next was called on the reply line. Not sure if that made sense, I had trouble coming up with a better wording than "making it new makes it new"

[sanddbox]

That was probably added by mistake - using next is fine since "yes" or "no" is only one word.

No, I think it is better to use nextLine in place of next. I believe his error was that by using next he read the line without advancing to the next line, then when the loop was ran next there was nothing left in the line to assign to sentence. sentence then became null, thus a length of 0, thus a IndexOutOfBounds error. I could be wrong though, it's been a few years since I used Java.

That would actually make sense. I guess we didn't have to initialize a new scanner every time

[TheMindRapist]

Here is the final code "I think." I also added a reset of question and exclam at the end of the "do" to make the responses correct when the type of response changes.

This isn't a big deal, but it's pointless to do assign true to answer each time reply is "yes" - answer starts off as true, and when it becomes false the loop and program ends. That's why in my revised code I checked if reply wasn't equal to yes. Also, perhaps even simpler would be to set reply to "yes" initially and then have the condition of the loop be

Code: Select all

while(reply.equalsIgnoreCase("yes"))

which would cut out a variable from your code. Like I said in my last post though, I don't know if this is for an assignment and you have to practice booleans X number of times.

[Assassian360]

That was probably added by mistake - using next is fine since "yes" or "no" is only one word.

No, I think it is better to use nextLine in place of next. I believe his error was that by using next he read the line without advancing to the next line, then when the loop was ran next there was nothing left in the line to assign to sentence. sentence then became null, thus a length of 0, thus an IndexOutOfBounds error. I could be wrong though, it's been a few years since I used Java.

Yeah, TheMindRapist is right. You will encounter a very similar issue when trying to use the nextInt() or nextDouble() methods. Which is quite possible if you are doing some kind of course. Since it will take the relevant number/s out but it will leave it an an end of line (even though it skips over properly when you keep calling nextInt()). Causing this crash due to 0 string length from using nextLine(). I see lots of students try to get around this by creating new Scanner objects. If you know that after a number has been entered you are going to be entering a string, you can have a line:

keyboard.nextLine();

By itself, and that will clear the stream to be starting at the next line. I forget whether there is a better way.

[Amidda1217]

Code: Select all

reply = keyboard.nextLine();
          if (reply.equalsIgnoreCase("yes")) {
              answer = true; }
else {
        answer = false;}
            //System.out.println(sentence.charAt(length - 1)); //prints last char of sentence

instead of that i switched it to

Code: Select all

boolean answer = true;
if (reply.equalsIgnoreCase("no")){
answer = false;}

i can tell you guys are going to help me a lot at becoming more efficient. Thank you very much for all of the help.

[sanddbox]

You might as well instantiate answer up at the start of the method.

[Amidda1217]

You might as well instantiate answer up at the start of the method.

sorry i didn't mention that. It was already initiated before, i just changed it from false to true.

[sanddbox]

You might as well instantiate answer up at the start of the method.

sorry i didn't mention that. It was already initiated before, i just changed it from false to true.

I know - it just seems unnecessary to set it to true everytime "yes" is answered. If it's true by default all you have to do is change it to false when they say "no". Still, it makes no difference.

[TheMindRapist]

I know - it just seems unnecessary to set it to true everytime "yes" is answered. If it's true by default all you have to do is change it to false when they say "no". Still, it makes no difference.

I think (hope) that he meant the line

Code: Select all

boolean answer = true;

is outside the loop, at the beginning of his program, although that isn't at all clear from his post. I might be wrong though.

[Amidda1217]

I know - it just seems unnecessary to set it to true everytime "yes" is answered. If it's true by default all you have to do is change it to false when they say "no". Still, it makes no difference.

I think (hope) that he meant the line

Code: Select all

boolean answer = true;

is outside the loop, at the beginning of his program, although that isn't at all clear from his post. I might be wrong though.

Yes, that is exactly what I meant. I will try and make my posts more clear. boolean answer = true; is at the beginning of my program (outside the loop.)