C calculator I made:

[AgentDerp]

Okay, right now I am improving the structure and functionality of the code.
I'll post it when it is finished.

[msbachman]

You wanted to mold a shitty calculator that even my grandmother wouldn't be impressed with and SHOW IT OFF? Then you come here asking for constructive criticism and completely ignore what we tell you?

If you read his follow-up post, you'll see he never claimed to want to show this calculator off:

Constructive criticism: I'm not expert OR intermediate.
I'm just a beginner so the calculator was the best thing I ever made.

And I think why he initially responded as he did (to Goatboy) was to give a rationale for why he didn't make it better, i.e. that he didn't possess the knowledge.

It's not like he flew in here to trash the forum with a post like 'omg u suk fagg0ts chk 0ut ma 1337 c0d3z.' He came across a little defensive in his responses but all in all there's no way this guy belongs in the same forum as that retard 'whitekid'. We should be saving our best flames for people like that, imo.

[AgentDerp]

Meh.
My calculator is acting up.
It's producing 4 errors:
cal.c:21: error: switch quantity not an integer
cal.c:23: error: case label does not reduce to an integer constant
cal.c:33: error: switch quantity not an integer
cal.c:35: error: case label does not reduce to an integer constant

And here's my code:

Code: Select all

#include <stdio.h>

/* Demonstrates a console (text) calculator. */
   
int main(void)
{
    /* Declare the variables. */
    float numb1;
    float numb2;
    float result;
    int oper;
    short i = 0;
   
    /* Start while loop. */
    while (i==0)
    {
   puts("Enter the first decimal number. (0.0 to quit) ");
   scanf("%d", &numb1);
      
        /* Check to see if the user wants to quit. */
   switch (numb1)
   {
      case 0.0:
          /* Exit. */
          break;
   }
      
       puts("Enter the second decimal number. (0.0 to quit) ");
       scanf("%d", &numb2);
      
      /* Check again to see if the user wants to quit. */
      switch (numb1)
      {
          case 0.0:
             /* Exit. */
            break;
         
      }
      
       puts("Enter the ASCII operator (43 (adding), 45 (subtracting), 42 (multiplying), or 47 (dividing). ");
       scanf("%d", &oper);
       switch (oper)
        {
            case 43:
                result = numb1 + numb2;
                printf("The result is %d ", result);
            
            case 45:
             result = numb1 - numb2;
            printf("The result is %d ", result);
            
            case 42:
             result = numb1 * numb2;
            printf("The result is %d ", result);
            
            case 47:
                result = numb1 / numb2;
                printf("The result is %d ", result);
           
            default:
                puts("You have entered a wrong ASCII char.\n");
           
        }
   }
   return 0;
}


What's wrong with it? ;_;
(don't mind the spacing, the forums messed it up again)

[fashizzlepop]

Why the fuck would you help this kid?! He's an asshole. He doesn't want our feedback and there is no way in HELL I am ever going to help this kid out. I say take your errors and get the fuck out of here.

[sanddbox]

Meh.
My calculator is acting up.
It's producing 4 errors:
cal.c:21: error: switch quantity not an integer
cal.c:23: error: case label does not reduce to an integer constant
cal.c:33: error: switch quantity not an integer
cal.c:35: error: case label does not reduce to an integer constant

And here's my code:

Code: Select all

#include <stdio.h>

/* Demonstrates a console (text) calculator. */
   
int main(void)
{
    /* Declare the variables. */
    float numb1;
    float numb2;
    float result;
    int oper;
    short i = 0;
   
    /* Start while loop. */
    while (i==0)
    {
   puts("Enter the first decimal number. (0.0 to quit) ");
   scanf("%d", &numb1);
      
        /* Check to see if the user wants to quit. */
   switch (numb1)
   {
      case 0.0:
          /* Exit. */
          break;
   }
      
       puts("Enter the second decimal number. (0.0 to quit) ");
       scanf("%d", &numb2);
      
      /* Check again to see if the user wants to quit. */
      switch (numb1)
      {
          case 0.0:
             /* Exit. */
            break;
         
      }
      
       puts("Enter the ASCII operator (43 (adding), 45 (subtracting), 42 (multiplying), or 47 (dividing). ");
       scanf("%d", &oper);
       switch (oper)
        {
            case 43:
                result = numb1 + numb2;
                printf("The result is %d ", result);
            
            case 45:
             result = numb1 - numb2;
            printf("The result is %d ", result);
            
            case 42:
             result = numb1 * numb2;
            printf("The result is %d ", result);
            
            case 47:
                result = numb1 / numb2;
                printf("The result is %d ", result);
           
            default:
                puts("You have entered a wrong ASCII char.\n");
           
        }
   }
   return 0;
}


What's wrong with it? ;_;
(don't mind the spacing, the forums messed it up again)

My C is rusty but I'm pretty sure you can't use switch with integers.

[AgentDerp]

Meh.
My calculator is acting up.
It's producing 4 errors:
cal.c:21: error: switch quantity not an integer
cal.c:23: error: case label does not reduce to an integer constant
cal.c:33: error: switch quantity not an integer
cal.c:35: error: case label does not reduce to an integer constant

And here's my code:

Code: Select all

#include <stdio.h>

/* Demonstrates a console (text) calculator. */
   
int main(void)
{
    /* Declare the variables. */
    float numb1;
    float numb2;
    float result;
    int oper;
    short i = 0;
   
    /* Start while loop. */
    while (i==0)
    {
   puts("Enter the first decimal number. (0.0 to quit) ");
   scanf("%d", &numb1);
      
        /* Check to see if the user wants to quit. */
   switch (numb1)
   {
      case 0.0:
          /* Exit. */
          break;
   }
      
       puts("Enter the second decimal number. (0.0 to quit) ");
       scanf("%d", &numb2);
      
      /* Check again to see if the user wants to quit. */
      switch (numb1)
      {
          case 0.0:
             /* Exit. */
            break;
         
      }
      
       puts("Enter the ASCII operator (43 (adding), 45 (subtracting), 42 (multiplying), or 47 (dividing). ");
       scanf("%d", &oper);
       switch (oper)
        {
            case 43:
                result = numb1 + numb2;
                printf("The result is %d ", result);
            
            case 45:
             result = numb1 - numb2;
            printf("The result is %d ", result);
            
            case 42:
             result = numb1 * numb2;
            printf("The result is %d ", result);
            
            case 47:
                result = numb1 / numb2;
                printf("The result is %d ", result);
           
            default:
                puts("You have entered a wrong ASCII char.\n");
           
        }
   }
   return 0;
}


What's wrong with it? ;_;
(don't mind the spacing, the forums messed it up again)

My C is rusty but I'm pretty sure you can't use switch with integers.

It says "switch quantity not an integer"
Which probably mean you HAVE to put an integer in.

[sanddbox]

Meh.
My calculator is acting up.
It's producing 4 errors:
cal.c:21: error: switch quantity not an integer
cal.c:23: error: case label does not reduce to an integer constant
cal.c:33: error: switch quantity not an integer
cal.c:35: error: case label does not reduce to an integer constant

And here's my code:

Code: Select all

#include <stdio.h>

/* Demonstrates a console (text) calculator. */
   
int main(void)
{
    /* Declare the variables. */
    float numb1;
    float numb2;
    float result;
    int oper;
    short i = 0;
   
    /* Start while loop. */
    while (i==0)
    {
   puts("Enter the first decimal number. (0.0 to quit) ");
   scanf("%d", &numb1);
      
        /* Check to see if the user wants to quit. */
   switch (numb1)
   {
      case 0.0:
          /* Exit. */
          break;
   }
      
       puts("Enter the second decimal number. (0.0 to quit) ");
       scanf("%d", &numb2);
      
      /* Check again to see if the user wants to quit. */
      switch (numb1)
      {
          case 0.0:
             /* Exit. */
            break;
         
      }
      
       puts("Enter the ASCII operator (43 (adding), 45 (subtracting), 42 (multiplying), or 47 (dividing). ");
       scanf("%d", &oper);
       switch (oper)
        {
            case 43:
                result = numb1 + numb2;
                printf("The result is %d ", result);
            
            case 45:
             result = numb1 - numb2;
            printf("The result is %d ", result);
            
            case 42:
             result = numb1 * numb2;
            printf("The result is %d ", result);
            
            case 47:
                result = numb1 / numb2;
                printf("The result is %d ", result);
           
            default:
                puts("You have entered a wrong ASCII char.\n");
           
        }
   }
   return 0;
}


What's wrong with it? ;_;
(don't mind the spacing, the forums messed it up again)

My C is rusty but I'm pretty sure you can't use switch with integers.

It says "switch quantity not an integer"
Which probably mean you HAVE to put an integer in.

Sorry, that's what I meant. You can't use non-integers

[Assassian360]

Meh.
My calculator is acting up.
It's producing 4 errors:
cal.c:21: error: switch quantity not an integer
cal.c:23: error: case label does not reduce to an integer constant
cal.c:33: error: switch quantity not an integer
cal.c:35: error: case label does not reduce to an integer constant

And here's my code:

Code: Select all

#include <stdio.h>

/* Demonstrates a console (text) calculator. */
   
int main(void)
{
    /* Declare the variables. */
    float numb1;
    float numb2;
    float result;
    int oper;
    short i = 0;
   
    /* Start while loop. */
    while (i==0)
    {
   puts("Enter the first decimal number. (0.0 to quit) ");
   scanf("%d", &numb1);
      
        /* Check to see if the user wants to quit. */
   switch (numb1)
   {
      case 0.0:
          /* Exit. */
          break;
   }
      
       puts("Enter the second decimal number. (0.0 to quit) ");
       scanf("%d", &numb2);
      
      /* Check again to see if the user wants to quit. */
      switch (numb1)
      {
          case 0.0:
             /* Exit. */
            break;
         
      }
      
       puts("Enter the ASCII operator (43 (adding), 45 (subtracting), 42 (multiplying), or 47 (dividing). ");
       scanf("%d", &oper);
       switch (oper)
        {
            case 43:
                result = numb1 + numb2;
                printf("The result is %d ", result);
            
            case 45:
             result = numb1 - numb2;
            printf("The result is %d ", result);
            
            case 42:
             result = numb1 * numb2;
            printf("The result is %d ", result);
            
            case 47:
                result = numb1 / numb2;
                printf("The result is %d ", result);
           
            default:
                puts("You have entered a wrong ASCII char.\n");
           
        }
   }
   return 0;
}


What's wrong with it? ;_;
(don't mind the spacing, the forums messed it up again)

So far the guys have just said you are allowed Integers. You can also have char types as the method of switching. (this is because they have unique integer numbers representing them)

eg:

Code: Select all

char operator = '*';
switch(operator)
{
        case '+':
                  // deal with +
                  break;
        case '-':
                 // deal with -
                 break;
        case 'A':
                // not for the calculator but to demonstrate that you can use letters etc
                break;
        case '*':
                // deal with *
        ....... // etc
}


Switch statements should really be used when you have a number of different options to actually choose from. The first few switch statements you have put in early on deal with single cases (where you seem to be checking for exiting). These should be checked using IF statements instead. I may be wrong, but I would assume you can type in 0 or 0.0 in your input and it would still detect it correctly (same with any other number) which also means if you are doing a direct comparison you can just write it as: if(numb1 == 0) for example.

You seem to want an infinite loop, hence have gone for the while(i == 0). Rather than dedicating a variable that is never going to change, you could just write while(true) or for(;;) and it will make your loop infinite till the user chooses to quit.

Hope this helps

[Goatboy]

We should not be helping this kid. He has made it VERY clear in numerous posts that he does not want criticism, nor does he plan on improving the code. If he wants help, he needs to ask for it politely, sans the attitude.

[fashizzlepop]

I couldn't agree more goatboy (as you've probably noticed). This should be locked. And I am glad it was moved to IC.